I would say it's good to do both. Yes, practice without to really nail your playing and get that down, but practice with effects too to get to know how to use them well and get used to switching them in/out during songs. It's all very well knowing a song inside out, but if you then throw a pedal into the equation, it can trip you up at the last minute (figuratively or literally...).